Skip to content

Small cleanup, removed duplicated keys from array #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Small cleanup, removed duplicated keys from array #495

wants to merge 1 commit into from

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Apr 19, 2025 •
edited
Loading

'proc_open' => null, is already defined in the same array on line 38, it makes no sense to keep both around.

Found with phpstan (while running it from inside magento core codebase):

$ ./vendor/bin/phpstan analyse --level=0 -c dev/tests/static/testsuite/Magento/Test/Php/_files/phpstan/phpstan.neon vendor/magento | grep 'duplicate'
 3325/3325 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

  28     Array has 2 duplicate keys with value 'proc_open' ('proc_open', 'proc_open').

@hostep hostep mentioned this pull request Apr 19, 2025
Merged
6 tasks
@m2-assistant m2-assistant bot mentioned this pull request Apr 22, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

+1 more reviewer

@fredden fredden fredden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hostep @fredden @ihor-sviziev